Logdet Bug Similar to e9f8c64

google-deepmind / ferminet

An implementation of the Fermionic Neural Network for ab-initio electronic structure calculations

Apache License 2.0

740 stars 129 forks source link

Closed mrlazy1708 closed 7 months ago

mrlazy1708 commented 7 months ago

Noticed that in psiformer.py, line 448, the logdet calculation for NES is still wrong by multiplying ndets together:

      return batch_logdet_matmul(*orbitals)

A similar issue was fixed for FermiNet in e9f8c64ee170125e625c70390b94019723f8671b.

jsspencer commented 7 months ago

Thanks for spotting this, it's now fixed