google-deepmind / ferminet

An implementation of the Fermionic Neural Network for ab-initio electronic structure calculations
Apache License 2.0
740 stars 129 forks source link

pin folx version #79

Closed Ruturaj4 closed 1 month ago

Ruturaj4 commented 2 months ago

folx can recently only used with python 3.11+.

Could you be able to use a specific folx version what would avoid such requirements?

We are using ferminet in project and that forces us to use python 3.11. However, we can't move to python 3.11 immediately.

jsspencer commented 1 month ago

Sorry for the slow reply. We do track folx quite closely as developments there are often useful for our research.

One option would be to tag an older version of this repository which works with an older version of folx that doesn't require 3.11. Would this be acceptable? If you require latest features of this project, then restricting us to an older folx version is not feasible.

Note that we test on python 3.11, so there is a strong chance that we use features in python 3.11 in the future.

Ruturaj4 commented 1 month ago

yup, currently we are using an older version of folx. thanks for letting know.