search

google-deepmind / gemma

Open weights LLM from Google DeepMind.
http://ai.google.dev/gemma
Apache License 2.0
2.5k stars 316 forks source link

Issue with unit tests on NVIdia A100 (GPU) #33

Open DwarKapex opened 6 months ago

DwarKapex commented 6 months ago

Hi everyone.

I see the issue when run unit tests on NVidia A100 (GPU). Here is the link for more details.

Briefly:

=========================== short test summary info ============================
FAILED opt/gemma/gemma/layers_test.py::EinsumTest::test_rmsnorm0 - AssertionE...
FAILED opt/gemma/gemma/modules_test.py::FeedForwardTest::test_ffw0 - Assertio...
FAILED opt/gemma/gemma/positional_embeddings_test.py::PositionalEmbeddingsTest::test_adds_positional_embeddings0
FAILED opt/gemma/gemma/sampler_test.py::SamplerTest::test_forward_equivalence
================== 4 failed, 12 passed, 2 warnings in 26.55s ===================

The first 3 is similar to issues on V100 (#32), but the last one:

  1. test_forward_equivalence link. Can you relax the tolerance when run on GPUs?
DwarKapex commented 6 months ago

Hi folks. Any update on these 2 issues?