google-deepmind / graph_nets

Build Graph Nets in Tensorflow
https://arxiv.org/abs/1806.01261
Apache License 2.0
5.34k stars 783 forks source link

Update graph_nets_basic example to TF2 #117

Closed Mistobaan closed 3 years ago

Mistobaan commented 4 years ago

see #115

alvarosg commented 4 years ago

Thanks for the PR @Mistobaan !

It seems like the outputs of the notebook look reasonable! To make the review easier, do you think it would be possible to:

Thanks in advance :)

Mistobaan commented 4 years ago

@alvarosg I agree with your points. re-created the commits and pushed.

alvarosg commented 4 years ago

Just to update on my end:

Thanks for the latest changes @Mistobaan , I will review it all at once the small TF2 specific example of usage with tf.function is provided, please let me know if plans change :)

zafarali commented 3 years ago

Hi @Mistobaan, I was wondering if you were planning to add the tf.function example. Let me know!

alvarosg commented 3 years ago

Thanks for the contribution!

I am merging this for now. Please, let me know if you are interested on adding the tf.function example on a separate PR.

Thanks again!