Open maguileracanon opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks for the PR and the initiative @maguileracanon !
To make the review easier, do you think it would be possible to:
Thanks in advance :)
Thanks, do you think it would be possible to rewrite the commit history to have just those two CLs (Similarly to how it was done here ).
Currently, the diff of the "update to tf2" does not pick up on the specific changes that were made (ideally the changes would be able to highlight the tf2 difference specifically). If possible it would look more similar to this diff.
I know github support for diffs in colab notebooks is not great, and maybe the changes are large enough that the diff cannot figure out the shared parts. But otherwise, it is hard to see what update to tf2
and Revert "update to tf2"
commits are doing :)
Hi ! yes. Sorry, the revert commit was because, as you mention, I noticed that the diff for the first 2 commits wasn't picking up the difference between them so I tried to revert it and see if I can find another solution. I still don't really understand why is taking the diff as if I had deleted everything and placed it again. I'll post a comment when I solve it.
Ok, the problem was that I was deleting the output at the end and that was kind of re-writting the entire notebook. If you look at the last commit e82bd5befac1847f68bf7aa4fa00e74a28215af4 then the diff should be clear for review. I hope this is what you need, but let me know if there is something else you need.
That looks much better! It could be great if you could get rid of the earlier commits so it shows a single first commit with the full copy (e.g. a large diff), and then the second commit with a diff similar to what you have now in the last commit. Otherwise, it is hard to track all of the changes in the earlier commits.
One option could be to squash all of the commits (except the last one). This should result in a single commit that corresponds purely to the file move.
Alternatively, it may be easier to start again, by:
ok. The commit history looks a little bit tidier now :)
Hi @maguileracanon , I sent my review a while back, please let me know if you are still planning to get back to this :)
Hello, graph-nets Authors!! Following the discussion in #115 I wanted to contribute and adapted the shortest_path example to run in TF2 and implementing the sonnet Adam optimizer. I added a couple of functions to make it runnable. Ideally, they should probably live inside utils_np or utils_tf but I kept them here for simplicity. I hope it is useful!