Closed DLPerf closed 2 years ago
Thank you for your message! Since this is a simple test we favored code simplicity over performance by reducing the span of the session variable in the code. But please continue to report any potential performance issues you may find in the core of the library!
Thanks for your reply. @alvarosg
Hello! I've found a performance issue in /graph_nets/tests/utils_tf_test.py:
with tf.Session() as sess
(here) is repeatedly called in the loopfor graph_dict in self.graphs_dicts_in
(here).tf.Session
being defined repeatedly could lead to incremental overhead. If you definetf.Session
out of the loop and passtf.Session
as a parameter to the loop, your program would be much more efficient. Here is the Stack Overflow post to support it.Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.