google-deepmind / graphcast

Apache License 2.0
4.37k stars 538 forks source link

dm-tree #25

Closed Lewington-pitsos closed 6 months ago

Lewington-pitsos commented 7 months ago

prior to this change, after installing graphcast with pip install git+https://github.com/deepmind/graphcast.git and running it via ai-models-graphcast I would get this error

You need to install Graphcast from git to use this model. See README.md for details.
Traceback (most recent call last):
  File "/home/lewington/code/ai-models-graphcast/ai_models_graphcast/model.py", line 29, in <module>
    from graphcast import (
  File "/home/lewington/code/ai-models-graphcast/venv/lib/python3.10/site-packages/graphcast/autoregressive.py", line 20, in <module>
    from graphcast import predictor_base
  File "/home/lewington/code/ai-models-graphcast/venv/lib/python3.10/site-packages/graphcast/predictor_base.py", line 21, in <module>
    from graphcast import xarray_jax
  File "/home/lewington/code/ai-models-graphcast/venv/lib/python3.10/site-packages/graphcast/xarray_jax.py", line 107, in <module>
    import tree
ModuleNotFoundError: No module named 'tree'

I tried pip install git+https://github.com/Lewington-pitsos/graphcast.git@fix-requirements instead (i.e. installing this branch with the change) and the error does not occur.

I believe that the old setup.py was causing us to install another unrelated package