Open 98devin opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hi 98devin, Thank you for the suggested fix. It looks right to me. Could you please sign the CLA, and I'll merge those changes?
Fixes
HanabiState.fireworks()
returning incorrect data when called on a copied HanabiState object.Came across this bug in work-related project. The bug is pretty easily fixed by retrieving the parent game of the state into an existing
pyhanabi_game_t*
instead of returning a void pointer as was done before.Steps to reproduce the bug as it existed:
HanabiState
object by callingHanabiState.copy
or using the copy constructor manuallyHanabiState._game
will receive ahanabi_learning_env::HanabiGame*
rather thanpyhanabi_game_t*
.HanabiState.fireworks()
and any derivedHanabiObservation.fireworks()
calls will return bad data, becauselib.NumPlayers
/lib.NumColors
/lib.NumRanks
will access garbage memory when called on the resulting_game
field.