search

google-deepmind / lab

A customisable 3D platform for agent-based AI research
Other
7.06k stars 1.36k forks source link

Fix exception causes in game_controller.py #244

Closed cool-RR closed 1 year ago

cool-RR commented 1 year ago

More context for this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with

cool-RR commented 1 year ago

Looks like the CI failure is not related to my changes.

tkoeppe commented 1 year ago

No, we need to update the requirements to at least C++14 first, since Abseil has those requirements too now.

cool-RR commented 1 year ago

So this PR can proceed and we can ignore the CI failure?

tkoeppe commented 1 year ago

Hang on, I'm updating the requirements to C++17, then the tests should pass.

cool-RR commented 1 year ago

@tkoeppe Would that update come as a commit to the master branch? Because my commit is already rebased on top of the latest commit on master.

tkoeppe commented 1 year ago

I'll be in touch. I need to update a few things first, it seems.

tkoeppe commented 1 year ago

Can you please rebase and retry now?

tkoeppe commented 1 year ago

Thank you!