Closed guillaume-chevalier closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
(To be precise, my current employer signed the corporate CLA, so he added me to a Google Group containing my email to allow me to contribute)
CLAs look good, thanks!
Thanks!
To use a recent version of Sonnet, I did changes regarding the new behavior, see: https://github.com/deepmind/sonnet/commit/601c4f393037ea76c625d39c88d9d576f438c7ae
The tests pass, except for two parameterizations of
testValues
inQuadraticTest
ofproblems_test.py
. It looks like floating points rounding errors that are somehow unrelated to my changes:I tested the changes under: