google-deepmind / learning-to-learn

Learning to Learn in TensorFlow
https://arxiv.org/abs/1606.04474
Apache License 2.0
4.06k stars 599 forks source link

Sonnet's base AbstractModule now requires named arguments (Sonnet v1.6 and Python 3) #19

Closed guillaume-chevalier closed 7 years ago

guillaume-chevalier commented 7 years ago

To use a recent version of Sonnet, I did changes regarding the new behavior, see: https://github.com/deepmind/sonnet/commit/601c4f393037ea76c625d39c88d9d576f438c7ae

The tests pass, except for two parameterizations of testValues in QuadraticTest of problems_test.py. It looks like floating points rounding errors that are somehow unrelated to my changes:

======================================================================
FAIL: testValues_0 (__main__.QuadraticTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/miniconda/lib/python3.6/site-packages/nose_parameterized/parameterized.py", line 392, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "problems_test.py", line 111, in testValues
    self.assertEqual(output, ((w * value) - y)**2)
AssertionError: 24.999998 != 25.0

======================================================================
FAIL: testValues_3 (__main__.QuadraticTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/miniconda/lib/python3.6/site-packages/nose_parameterized/parameterized.py", line 392, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "problems_test.py", line 111, in testValues
    self.assertEqual(output, ((w * value) - y)**2)
AssertionError: 288.99997 != 289.0

I tested the changes under:

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


guillaume-chevalier commented 7 years ago

I signed it!

guillaume-chevalier commented 7 years ago

(To be precise, my current employer signed the corporate CLA, so he added me to a Google Group containing my email to allow me to contribute)

googlebot commented 7 years ago

CLAs look good, thanks!

sergomezcol commented 7 years ago

Thanks!