search

google-deepmind / mujoco

Multi-Joint dynamics with Contact. A general purpose physics simulator.
https://mujoco.org
Apache License 2.0
7.47k stars 734 forks source link

Consistent spacing in python/tutorial.ipynb #1713

Closed fanminshi closed 2 weeks ago

fanminshi commented 3 weeks ago

Improve inconsistency of grouping variables between code blocks.

google-cla[bot] commented 3 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

yuvaltassa commented 3 weeks ago

Nice! Can you do the CLA thing please? Thanks!

fanminshi commented 3 weeks ago

@yuvaltassa yep i did the CLA thing!

fanminshi commented 2 weeks ago

@yuvaltassa is the CL ready to be merged? I have other CLs to be submited after this. I find few improvments on style for this tutorials.

yuvaltassa commented 2 weeks ago

Thanks for the reminder, I'll get on it 🙂

yuvaltassa commented 2 weeks ago

Something funny with importing this, can you try syncing to head please?

fanminshi commented 2 weeks ago

@yuvaltassa i rebased this commit against main. let me know if it works on yourside now.

yuvaltassa commented 2 weeks ago

Okay this is now at head, thanks so much @fanminshi !

One thing that we probably need to do is change all uses of Renderer to use the context manager format, people keep tripping up on Renderer instances hanging around e.g. #1185 ...

Future PRs to notebooks should get pulled in much quicker, I needed to sort some issues on our end

fanminshi commented 1 week ago

great thanks!