search

google-deepmind / mujoco

Multi-Joint dynamics with Contact. A general purpose physics simulator.
https://mujoco.org
Apache License 2.0
7.47k stars 734 forks source link

Fix MjHingeJoint.cs range with MakeLocaleInvariant #1721

Open stonfute opened 3 weeks ago

stonfute commented 3 weeks ago

Seems to fix issues #1394 #845 by using localeInvariant on range

Balint-H commented 2 weeks ago

@erez-tom LGTM!

Thanks for the contribution @stonfute! It doesn't completely fix #1709, but #845 could be solved by this (pending on confirmation from the issue's original author)

stonfute commented 2 weeks ago

It doesn't completely fix #1709, but #845 could be solved by this (pending on confirmation from the issue's original author)

My bad, wrong issue mentioned. I meant it will fix #845 according to sample xml provided. And also related to #1394 (hinge joint part with range issue)