Closed 7oponaut closed 3 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Thanks for these @7oponaut. We should probably check if the same changes should be made to the other Unitree MJX variants. Will wait on @erikfrey to review!
@erikfrey I'm okay with increasing friction, but since elliptic is now supported by MJX, should we not switch to impratio + elliptic?
As a rule of thumb, for locomotion you can rely on pyramidal friction - it's cheaper to simulate but still transfers to real just fine.
Gotcha, then all good for increasing friction!
@erikfrey Can we get this merged in?
@7oponaut Can you sign the CLA?
@kevinzakka yes, once CLA is signed.
Sorry for taking your time, I was under the impression that I am contributing to an open source repository.
I am not comfortable with signing the CLA.
I'm taking issue with 3) in the CLA: I'm not a lawyer or a Google employee and I don't want to deal with litigatory issues in case Google later commercializes any of this repository and gets sued for whatever reason.
I had two issues when attempting to use
unitree_go2/go2_mjx.xml
in scenes with hfields such asgoogle_barkour_vb/scene_hfield_mjx.xml
:1) the
margin
attribute in thego2
class default section results in the following error:2) the impratio="100" option setting makes the scene unstable with mjx acceleration (specifically, I encountered nan qpos values)
This PR removes these two attributes, resulting in no
margin
and animpratio="1"
default.I don't have a full understanding of how these changes affect the simulation. Please determine if they should be merged.
@saran-t requested this PR after encountering my post about the instability on X.
p.s. My version of the file has additional changes which might be helpful