search

google-deepmind / mujoco_mpc

Real-time behaviour synthesis with MuJoCo, using Predictive Control
https://github.com/deepmind/mujoco_mpc
Apache License 2.0
952 stars 142 forks source link

Tag and version mjpc #207

Closed vikashplus closed 7 months ago

vikashplus commented 10 months ago

Hi would it be possible to version and tag mujoco_mpc. Its under active development and being able to identify stable points in the repo has been a challenge.

Also shout out to @thowell for always helping me navigating the changes.

thowell commented 8 months ago

MJPC commits are now pinned to a specific MuJoCo version .

vikashplus commented 8 months ago

@thowell -- any plans for tagging the MJPC itself?

erez-tom commented 8 months ago

Since we don't release artefacts, why do you need us to do the tagging on our side? Couldn't you just grab the hash of a snapshot that's proving useful to you and stick with it?

vikashplus commented 8 months ago

Tags are useful to identify where are the stable points, especially for repos that are under continuous development. Not all hashes are stable. Without tags, one has to search all the hash commits to find a place where the repo was most stable. Developers adding tags to specific hashes can make life of a user easier as they indicate which tagged-hashes are stable points for users to resort to.

thowell commented 7 months ago

I agree with @vikashplus, this is a really useful feature.

@erez-tom I think the latest branch is pretty stable. Can you tag a commit? Going forward perhaps we can tag a version of MJPC when there is a major MuJoCo version update (we would want to bump the MuJoCo version in MJPC anyway)?

nimrod-gileadi commented 7 months ago

Done. https://github.com/google-deepmind/mujoco_mpc/releases/tag/v0.0.1