google-deepmind / mujoco_mpc

Real-time behaviour synthesis with MuJoCo, using Predictive Control
https://github.com/deepmind/mujoco_mpc
Apache License 2.0
913 stars 135 forks source link

Allegro Cube Rotation Task #243

Closed alberthli closed 5 months ago

alberthli commented 6 months ago

This PR adds the Allegro cube rotation task to mujoco_mpc.

thowell commented 6 months ago

@yuvaltassa should we create a tasks/common_assets directory to store the cube model so it doesn't appear in both the shadow and allegro hand tasks?

thowell commented 6 months ago

Realized we are missing a bunch of specifications from the contributing docs. Started adding that information here #244.

thowell commented 6 months ago

Nice work so far! I made the asset directory + minor changes here: https://github.com/alberthli/mujoco_mpc/pull/1

thowell commented 6 months ago

Once the PR on your branch is merged, LGTM.

thowell commented 6 months ago

@alberthli can you "resolve" the last conversation above (it's complete) and then @erez-tom can you approve?