search

google-deepmind / mujoco_mpc

Real-time behaviour synthesis with MuJoCo, using Predictive Control
https://github.com/deepmind/mujoco_mpc
Apache License 2.0
913 stars 135 forks source link

#219 Update MujocoLinkOptions.cmake #253

Closed keszegrobert closed 6 months ago

keszegrobert commented 6 months ago

According to the CMake documentation check_c_source_compiles function needs to have the linker flags defined in CMAKE_REQUIRED_LINK_OPTIONS starting with CMake 3.14. In the main CMakeLists.txt I have seen that the minimum version of CMake must be 3.16

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

thowell commented 6 months ago

@keszegrobert thanks for the PR! Can you please complete the Google CLA?

Do we need to modify this file for the same thing as well?

keszegrobert commented 6 months ago

I don't think the CheckAvxSupport needs to be changed