Closed rkourdis closed 4 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
@nimrod-gileadi Thanks for having a look! I've just rebased to latest main
and for some reason it dismissed the review - let me know if we can merge when you have time :))
@rkourdis can you update your branch so we can merge this PR?
@thowell Just updated the branch, thanks!
On Windows, including "Windows.h" defines min() and max() macros that clash with the STL functions under
<algorithm>
.This causes a compilation error on Visual Studio 2022:
Defining
NOMINMAX
before the include disables the definition of these macros, allowing the use ofstd::max()
from<algorithm>
.