Open MoritzMeser opened 1 month ago
Thanks for the contribution! It looks like these tasks are based on HumanoidBench? What kinds of success are you seeing with these tasks using MJPC?
That's right, it's based on HumanoidBench.
The success of tasks like standing and walking is very good. In terms of reward, these tasks are as good as solved, even if the behavior seems very unrealistic. (Like jumping on one leg).
However, there is no success in more complicated tasks, where the robot has to interact with objects.
This is excellent work!
We should think about the best way to manage merging all of this code since the PR is quite large (+2000 file changes). I think the best route is to open an issue where we can have all discussion about this set of humanoid benchmark tasks. We can then work on smaller PRs consisting of a single task (or a small number). This makes reviews more manageable.
I had a number of thoughts/comments (in no particular order) as I looked at code:
As next steps:
Sound good?
Thanks for taking the time to review my pull request. Your plan sounds like a good approach to manage this integration.
I will reach out to you once the steps you mention are implemented.
Thanks again for your guidance. I look forward to our collaboration.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.