search

google-deepmind / open_spiel

OpenSpiel is a collection of environments and algorithms for research in general reinforcement learning and search/planning in games.
Apache License 2.0
4.26k stars 934 forks source link

universal_poker not registered in colabs #189

Closed VogtAI closed 3 years ago

VogtAI commented 4 years ago

I simply concatenated "install_open_spiel.ipynb" and "test_universal_poker.ipynb" from open_spiel/open_spiel/colabs/ in Google Colab. However I get the error: "RuntimeError: Unknown game 'universal_poker'. Available games are:"

lanctot commented 4 years ago

Hi @VogtAI, this is because that game requires an optional dependency (the ACPC code base) as a dependency which we have disabled by default.

To enable it, you will need to clone the ACPC code into the proper directory (see install.sh) and then prepend the build command with BUILD_WITH_ACPC="ON"

lanctot commented 4 years ago

Thinking more: having the appropriate commands in the colab commented out would be good. That way people can enable poker just by deleting a few characters. I will suggest it to the team, will probably go into next Monday's update.

Thanks for pointing this out.

krfgbhoiaeuzr commented 3 years ago

There seems to be a regression here as the same problem is happening again with the latest versions of "install_open_spiel.ipynb" and "test_universal_poker.ipynb". Also, it's not immediatly clear to new users how to build with BUILD_WITH_ACPC="ON".

lanctot commented 3 years ago

Arghh... a test case I forgot to check, sorry!

The release did not include the optional dependencies for the pip package for some reason. My bad, sorry, will fix tonight.. should be done in 4-5 hours.

lanctot commented 3 years ago

Hi @krfgbhoiaeuzr , ok it's fixed again... apologies!