search

google-deepmind / open_spiel

OpenSpiel is a collection of environments and algorithms for research in general reinforcement learning and search/planning in games.
Apache License 2.0
4.28k stars 937 forks source link

Preferred priority for PyTorch example contributions? #23

Closed seungjaeryanlee closed 5 years ago

seungjaeryanlee commented 5 years ago

I read contributing.md and saw that one of them was adding examples and supports for PyTorch. I wanted to contribute, but was wondering if you had particular algorithms or examples in mind to start with.

If there is no particular preference, I would like to start with DQN, imitating the style of the existing TensorFlow example in open_spiel/python/algorithms/dqn.py.

Thank you!

lanctot commented 5 years ago

I don't think we have any preferences on that. DQN seems like a great place to start!

lanctot commented 5 years ago

If you do implement anything using pytorch maybe put it in a subdirectory for now so we can more easily separate the pytorch and TF algorithms?

seungjaeryanlee commented 5 years ago

@lanctot I think that's a good good idea! Just to clarify, would it be a subdirectory in algorithms folder, or would it be another folder like pytorch_algorithms ?

In other words, open_spiel/open_spiel/python/algorithms/pytorch/ vs open_spiel/open_spiel/python/pytorch_algorithms/

lanctot commented 5 years ago

I was thinking a pytorch subdir directly under python/ for now. If we get enough pytorch contributions, we can do some re-organization later. How does that sound?

lanctot commented 5 years ago

@seungjaeryanlee going to close this one as it seems resolved, thanks!

seungjaeryanlee commented 5 years ago

Sounds good. Thank you!