Closed qmaai closed 4 years ago
Thanks @qmaai. @paulfmmuller, any ideas?
Hey @qmaai ,
Taking a look into it. Just to minimize time spent searching, do you confirm that this error pops up when running the example and setting --rectifier="rectified" ?
I don't believe it's possible to use joint probabilities for the moment in v2's example ; would you by any chance have been running v1 ? We were planning on ensuring and validating support for joint probabilities in the future, they may therefore not be too robust yet.
thank you Paul. I was using v2 with "--rectifier=rectified" flags. yup.
@qmaai did you see Paul's response that joint probabilities are not yet possible in the v2 example?
Shall we close this or is there continued work being done on it? @PaulFMMuller shall we raise an exception informing the user in this case?
Hey @qmaai , I ran the example with --rectifier="rectified" and didn't encounter an issue ; did you add any other flag, or do something else ? If so, and it's not supported yet, please don't hesitate to make a contribution :) Otherwise, if there's something I've missed, please don't hesitate to send the entire launch command so I can reproduce the bug.
Hi @qmaai just wondering if this has been resolved for you? If so I am inclined to close this issue for now. Let us know, thanks.
In https://github.com/deepmind/open_spiel/blob/master/open_spiel/python/algorithms/psro_v2/utils.py, function
sample_random_tensor_index(probabilities_of_index_tensor)
fails when running psro_v2_example.py with --rectified=True flags or any case where sample_joint. The functions could be modified into the following:`
`
here an extra shape is passed into
sample_random_tensor_index
becauseprobabilities_of_index_tensor
as a joint is a one-dimensional vector and its shape could not be used for unraveling.