Open gautierronan opened 1 day ago
Hey @gautierronan, Thanks for the PR! We'll need a test. Take look at this PR: https://github.com/google/jaxopt/pull/468 that added support for complex parameters for the lbfgs of jaxopt. I think you'll find all that you'll need in that PR. Thanks again!
@vroulet Should be good for review.
Closes https://github.com/google-deepmind/optax/issues/1141.
Not 100% sure that this doesn't break other things or fully works, but at least the MWE below seems to work fine.
Notice the
solve.update
call which requires ajnp.conj(grad)
twice. I believe this is correct and aligned with other optax solvers, but not sure either.