search

google-deepmind / optax

Optax is a gradient processing and optimization library for JAX.
https://optax.readthedocs.io
Apache License 2.0
1.57k stars 169 forks source link

Add a mathematical description of AdamW #894

Closed gbruno16 closed 3 months ago

gbruno16 commented 3 months ago

I added the mathematical description of AdamW starting from Adam's docstring. This is the result:

adamw
google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gbruno16 commented 3 months ago

I've made the corrections suggested. Let me know if something else is missing!

adamw
vroulet commented 3 months ago

Good to go, thank you again!

fabianp commented 3 months ago

merging now, thanks @gbruno16 for the contribution!