google-deepmind / perception_test

Apache License 2.0
185 stars 15 forks source link

code error in GQA #24

Open HouTong-s opened 2 months ago

HouTong-s commented 2 months ago

in the grounded_vqa.ipynb the following code may be wrong. combined_frame_id_dict = build_gt_ids(gt_tracks, q['answers'])

Because the q['answers'] is as the gt of function build_gt_ids() in this line, I think q['answers'] should be the track_ids of function build_gt_ids(). But I am not sure whether the gt should be True or False. def build_gt_ids( tracks: List[Dict[str, Any]], gt: bool, track_ids: List[int] = None )