google-deepmind / reverb

Reverb is an efficient and easy-to-use data storage and transport system designed for machine learning research
Apache License 2.0
704 stars 92 forks source link

Support for macOS #11

Open wjkaufman opened 4 years ago

wjkaufman commented 4 years ago

I'm using macOS (Catalina Version 10.15.6) as my main development environment, and it would be great to use Reverb on this OS.

alaterre commented 4 years ago

Upvote this! I'm working on mac as well, I have a DockerFile but it's really not as easy to develop. Same for colab, great but it quickly reaches its limit.

drozzy commented 4 years ago

It would be great if this worked on mac (and even windows?), so that we could run acme on other OSes as well. Thanks!

tfboyd commented 4 years ago

Docker is your best bet. https://github.com/deepmind/reverb/tree/master/reverb/pip_package

There is a desire to support Mac, but we do not use it internally and finding resources to make it work and then setup the same level of testing vs. "hope" it does not break is not easy. I know not everyone likes Docker but I personally love it because it keeps everything in a nice container (ha ha) and I can move it anywhere with limited issues.

I also know this is frustrating. If someone got it working we likely would try to setup testing. This does come up about once a quarter at our planning meetings. If it was pure python, it would be easy.

lifeiteng commented 3 years ago

@alaterre I have made a pull request #24, can you help me verify it?

tfboyd commented 3 years ago

I will bring this up at our sync tomorrow. Maybe we can provide some support. Your start is exciting.

On Fri, Nov 20, 2020, 9:55 PM Feiteng notifications@github.com wrote:

@alaterre https://github.com/alaterre I have made a pull request #24 https://github.com/deepmind/reverb/pull/24, can you help me verify it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/deepmind/reverb/issues/11#issuecomment-731514026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTF5MTCGK5GK7T7FR27HY3SQ5I55ANCNFSM4PX6JZ2A .

lifeiteng commented 3 years ago

@wjkaufman you can try my branch https://github.com/deepmind/reverb/pull/24

wookayin commented 1 year ago

The PR #24 is continued in #119.

cemlyn007 commented 1 year ago

I have got the latest version of Reverb to compile for Mac x86_64 and arm64. I could do an MR if people are interested?

cemlyn007 commented 1 year ago

Here you go #128