search

google-deepmind / reverb

Reverb is an efficient and easy-to-use data storage and transport system designed for machine learning research
Apache License 2.0
702 stars 93 forks source link

Support for macOS #119

Open lifeiteng opened 1 year ago

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lifeiteng commented 1 year ago

older PR https://github.com/deepmind/reverb/pull/24

lifeiteng commented 1 year ago

install tensorflow

# Fix symbol not found in flat namespace (__ZN10tensorflow4data16CapturedFunction11InstantiateEPNS0_15IteratorContextEPNSt3__110unique_ptrINS0_28InstantiatedCapturedFunctionENS4_14default_deleteIS6_EEEE)
# nm ..../python3.9/site-packages/tensorflow/libtensorflow_cc.2.dylib   | grep __ZN10tensorflow4data16CapturedFunction11InstantiateEPNS0
pip3.9 install tf-nightly

cc tests

>bash oss_build.sh --python 3.9
//reverb/cc:chunk_store_test                                    (cached) PASSED in 6.1s
//reverb/cc:chunker_test                                        (cached) PASSED in 11.7s
//reverb/cc:client_test                                         (cached) PASSED in 10.3s
//reverb/cc:rate_limiter_test                                   (cached) PASSED in 7.5s
//reverb/cc:sampler_test                                        (cached) PASSED in 13.6s
//reverb/cc:streaming_trajectory_writer_test                    (cached) PASSED in 4.7s
//reverb/cc:structured_writer_test                              (cached) PASSED in 9.2s
//reverb/cc:table_test                                          (cached) PASSED in 35.7s
//reverb/cc:tensor_compression_test                             (cached) PASSED in 7.9s
//reverb/cc:thread_stats_test                                   (cached) PASSED in 8.4s
//reverb/cc:trajectory_writer_test                              (cached) PASSED in 5.7s
//reverb/cc:writer_test                                         (cached) PASSED in 6.7s
//reverb/cc/ops:queue_writer_test                               (cached) PASSED in 9.6s
//reverb/cc/platform:net_test                                   (cached) PASSED in 7.9s
//reverb/cc/platform:server_test                                (cached) PASSED in 5.9s
//reverb/cc/platform:tfrecord_checkpointer_test                 (cached) PASSED in 8.3s
//reverb/cc/platform:thread_test                                (cached) PASSED in 8.3s
//reverb/cc/selectors:fifo_test                                 (cached) PASSED in 8.2s
//reverb/cc/selectors:heap_test                                 (cached) PASSED in 7.9s
//reverb/cc/selectors:lifo_test                                 (cached) PASSED in 4.9s
//reverb/cc/selectors:prioritized_test                          (cached) PASSED in 8.5s
//reverb/cc/selectors:uniform_test                              (cached) PASSED in 8.8s
//reverb/cc/support:cleanup_test                                (cached) PASSED in 7.0s
//reverb/cc/support:intrusive_heap_test                         (cached) PASSED in 8.1s
//reverb/cc/support:periodic_closure_test                       (cached) PASSED in 8.0s
//reverb/cc/support:queue_test                                  (cached) PASSED in 7.8s
//reverb/cc/support:signature_test                              (cached) PASSED in 8.5s
//reverb/cc/support:trajectory_util_test                        (cached) PASSED in 7.0s
//reverb/cc/support:unbounded_queue_test                        (cached) PASSED in 7.7s
//reverb/cc:reverb_service_impl_test                                     FAILED in 4.2s
  /private/var/tmp/_bazel_feiteng/ca326ebed4b7debf1bb1599cc92cdc26/execroot/reverb/bazel-out/darwin-opt/testlogs/reverb/cc/reverb_service_impl_test/test.log
//reverb/cc/support:state_statistics_test                                FAILED in 3.4s
  /private/var/tmp/_bazel_feiteng/ca326ebed4b7debf1bb1599cc92cdc26/execroot/reverb/bazel-out/darwin-opt/testlogs/reverb/cc/support/state_statistics_test/test.log

INFO: Build completed, 2 tests FAILED, 3 total actions

python tests

Ran 26 tests in 3.004s

OK
Python tests successful!!!
cemlyn007 commented 1 year ago

I just want to check in case I am wrong, but this MR is for macOS-x86_64 and does not support macOS-arm64?