search

google-deepmind / rlax

https://rlax.readthedocs.io
Apache License 2.0
1.24k stars 85 forks source link

Relax numpy version requirement #110

Closed wookayin closed 1 year ago

wookayin commented 1 year ago

1e2e4bcb4761ba6107fb565982f6cc2b951cbeb5 introduced version qualifier numpy < 1.23 due to failing tests with jax, but I believe this has been resolved with recent jax versions and we no longer need < 1.23.

I could write a trivial PR that fixes requirements.txt, but let me leave it to be handled by the rlax team because the commit does not specify at which jax version tests are failing, hopefully the CL can update jax and numpy version requirements.

/cc @katebaumli

KaleabTessera commented 1 year ago

This would important to fix since now you can't rlax with newer versions of jax or numpy.

katebaumli commented 1 year ago

Apologies for the delay. This should be fixed by https://github.com/deepmind/rlax/pull/114