google-deepmind / torax

TORAX: Tokamak transport simulation in JAX
https://torax.readthedocs.io
Other
345 stars 31 forks source link

Correct transport clipping for CGM model. #207

Closed copybara-service[bot] closed 3 months ago

copybara-service[bot] commented 3 months ago

Correct transport clipping for CGM model.

Previously transport coefficient clipping was incorrect. chi_i was initialized with chimin, and then overwritten by the CGM model for >0 values. However, 0<chi_i<chi_min would still make it through. Furthermore, chi_e and D transport coefficients were scaled to chi_i and then not clipped. The present clipping pattern is in line with qlknn.

Profile differences are within expectation, mostly within 1%, with 10% differences for density with particle transport with a pedestal, where the new profiles look more reasonable.

Preparation for moving all transport clipping up to the TransportModel class.