search

google-deepmind / torch-distributions

Probability distributions, wrapped for Torch.
BSD 3-Clause "New" or "Revised" License
61 stars 25 forks source link

Accept result tensor in *PDF() #10

Open jucor opened 11 years ago

jucor commented 11 years ago

Issue by jucor from Monday Nov 04, 2013 at 07:14 GMT Originally opened as https://github.com/jucor/torch-randomkit/issues/14

d11 commented 11 years ago

Yes - it works for poisson.pdf already, I think, since that uses the vectorise function. But we need some tests, and to apply this to the other functions too

jucor commented 11 years ago

Good to know that the basics are here. I think the most urgent will probably be mvn. We can probably factorize the dimension checking code that is in mvn.rnd() and reuse it for mvn.logpdf(), to make things easier.

On 18 Nov 2013, at 18:03, Dan Horgan notifications@github.com wrote:

Yes - it works for poisson.pdf already, I think, since that uses the vectorised function. But we need some tests, and to apply this to the other functions too

— Reply to this email directly or view it on GitHub.