google-deepmind / torch-distributions

Probability distributions, wrapped for Torch.
BSD 3-Clause "New" or "Revised" License
61 stars 25 forks source link

Require disambiguation for Gaussian(DxD, DxD) #12

Open jucor opened 11 years ago

jucor commented 11 years ago

Issue by jucor from Tuesday Nov 12, 2013 at 14:00 GMT Originally opened as https://github.com/jucor/torch-randomkit/issues/26


Pointed by @schaul: if calling with DxD mean and DxD covariance, do we want the D samples to be from one single full covariance matrix, or from D different diagonal covariance matrices ? This is ambiguous, so we should require the user to clarify her intent by passing a table with the flag {diagonal = true} or {diagonal = false}, in line with the options dicussed in #5 .