search

google-deepmind / torch-distributions

Probability distributions, wrapped for Torch.
BSD 3-Clause "New" or "Revised" License
61 stars 25 forks source link

Generate systematic tests for mvn.[log]pdf, as they are for mvn.rand #17

Open jucor opened 11 years ago

jucor commented 11 years ago

Hi @d11

Just to make sure that we cover all the tests, we should probably extend the systematicTestCases to call mvn.[log]pdf, don't you think?

I've started using mvnpdf quite a bit, so I discover corner cases that we didn't deal with (see #16) in rnd -- and some are probably lurking in the pdf.

d11 commented 11 years ago

Hmm, yes, I was also thinking that might be a good idea. I guess that we'll need different tables of inputs and functions for checking the results for the [log]pdf, but could reuse the in-between parts potentially.

On 22 Nov 2013, at 18:26, Julien Cornebise notifications@github.com wrote:

Hi @d11

Just to make sure that we cover all the tests, we should probably extend the systematicTestCases to call mvn.[log]pdf, don't you think?

I've started using mvnpdf quite a bit, so I discover corner cases that we didn't deal with (see #16) in rnd -- and some are probably lurking in the pdf.

— Reply to this email directly or view it on GitHub.