search

google-deepmind / tree

tree is a library for working with nested data structures
https://tree.readthedocs.io
Apache License 2.0
938 stars 59 forks source link

Update pybind version to v2.10.1 to support python 3.11 #91

Closed wookayin closed 1 year ago

wookayin commented 2 years ago

With pybind v2.6.2, dm-tree cannot be built on python 3.11.

Pybind v2.10.0 has support for python 3.11, so we upgrade the pybind dependency version so that dm-tree can be built.

For early adapters who'd like to install this PR version on python 3.11 until gets merged:

python3.11 -m pip install 'dm-tree @ git+https://github.com/deepmind/tree@refs/pull/91/head'
wookayin commented 2 years ago

A kind reminder /cc @superbobry. I think PRs made in DeepMind's OSS projects usually do not bring much attention to maintainers; please have it routed to whom it may concern.

wookayin commented 1 year ago

I've update pybind to 2.10.1 because 2.10.1 has the full support of Python 3.11 (2.10.0 has an initial support). Also added the PyPI classifier to setup.py.

It'd be great if dm-tree can be released sooner than later, maybe after going through some internal tests! I haven't updated CI build.yml yet (which is a trivial change though) as a first-time contributer cannot initiate the CI jobs, but this can be done on my PR as well if you'd prefer.

XuehaiPan commented 1 year ago

Maybe we need also to add py311 in the workflow file .github/workflow/build.yml?

https://github.com/deepmind/tree/blob/e39ab8327ed208bf7aba2e9aad5cd23aa75fa9e1/.github/workflows/build.yml#L35

https://github.com/deepmind/tree/blob/e39ab8327ed208bf7aba2e9aad5cd23aa75fa9e1/.github/workflows/build.yml#L85

wookayin commented 1 year ago

Agree with @XuehaiPan, no reason to not add here. I've added the CI configuration.

@superbobry It has been pretty a while. Can you please take some time to merge this and make a new dm-tree release sooner than later?

wookayin commented 1 year ago

@superbobry @saran-t bumping this and let me give you a kind reminder.

femtomc commented 1 year ago

Please, for the love of all that is holy, can one of the project maintainers merge this?

I'm restricted to 3.10~ on most of my existing JAX libraries because this single package hasn't updated to support 3.11.

tomhennigan commented 1 year ago

Hi @femtomc, I'll nudge maintainers in person on Monday to get this merged and a new release cut.

femtomc commented 1 year ago

Thank you -- sorry for my tone. I've been anxious to explore the speed ups in 3.11 :)