search

google-developer-training / advanced-android-testing

Android Testing Codelab
https://codelabs.developers.google.com/codelabs/android-testing/
Apache License 2.0
1.01k stars 677 forks source link

dagger2 #18

Closed cpeppas closed 8 years ago

cpeppas commented 8 years ago

I have forked this project and created a new branch using dagger2. See here https://github.com/cpeppas/android-testing/tree/dagger

I thought this might be useful because dagger2 is becoming very popular nowadays.

Because of the fact that I cannot do a PL of a new branch that does not exist on the original project that's why I am raising this as an issue

Let me know if you think it is somehow valuable so I can do a PL in some way.

slinzner commented 8 years ago

Thanks! This is great, we initially did not include dagger in the codelab on purpose, because we want it to be focused on testing rather than DI. The latter can be hard to wrap your head around if you never worked with it. I'm actually happy to link to it from the main readme file, even though did you see our latest project on Android architecture? It already comes with a MVP dagger variant.