google-developer-training / android-basics-kotlin-mars-photos-app

Apache License 2.0
92 stars 193 forks source link

Android Basics: Get data from the Internet #87

Closed hebadi closed 3 years ago

hebadi commented 3 years ago

name: Android Basics Unit 4 issue about: Report problems with the Android Basics Unit 4 codelabs title: 'Android Basics Unit 4 issue:' labels: '' assignees: ''


URL of codelab https://developer.android.com/codelabs/basic-android-kotlin-training-getting-data-internet?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-4-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-getting-data-internet#7

In which task and step of the codelab can this issue be found? Task: Update MarsApiService and OverviewViewModel Step: 5

Describe the problem the code snippet uses the "@GET("photo")" when it should be "@GET("photos")" also, the getPhotos() fun is not written as a suspend function when it should be declared as such

Steps to reproduce?

  1. Go to...
  2. Click on...
  3. See error...

Versions Android Studio version: API version of the emulator:

Additional information Include screenshots if they would be useful in clarifying the problem.

osuleymanova commented 3 years ago

61

69

72

osuleymanova commented 3 years ago

@hebadi Thank you for reaching out to us. The issue is fixed and published.