search

google-developer-training / android-kotlin-fundamentals-starter-apps

android-kotlin-fundamentals-starter-apps
Other
1.1k stars 3.32k forks source link

Missed Migration to androidx for Navigation Component. #23

Closed nyxee closed 4 years ago

nyxee commented 4 years ago

For GDGFinder-Starter

GIVEN IN THE CODE:

//app  build.gradle file:
version_navigation = "1.0.0"
classpath "android.arch.navigation:navigation-safe-args-gradle-plugin:$version_navigation"

//module  build.gradle file:
implementation "android.arch.navigation:navigation-fragment-ktx:$version_navigation"
implementation "android.arch.navigation:navigation-ui-ktx:$version_navigation"

CORRECTION:

//app  build.gradle
version_navigation = "2.3.0"
classpath "androidx.navigation:navigation-safe-args-gradle-plugin:$$version_navigation"

//module  build.gradle file:
implementation "androidx.navigation:navigation-fragment-ktx:$version_navigation" 
implementation "androidx.navigation:navigation-ui-ktx:$version_navigation"

The given code compiled correctly but led to an error on one of my devices (Samsung Galaxy TAB S6 SM-T865, Android 10 - API 29 ) while it worked on other devices.

ERROR: navAndXError.txt

android-dev-lxl commented 4 years ago

This is fixed now. Thank you for reporting.