google-developer-training / basic-android-kotlin-compose-birthday-card-app

Apache License 2.0
125 stars 95 forks source link

Add images: Android Basics with Compose #868

Open asmodeo1 opened 1 month ago

asmodeo1 commented 1 month ago

URL of codelab

https://developer.android.com/codelabs/basic-android-kotlin-compose-add-images

In which task and step of the codelab can this issue be found?

  1. Adopt good code practices

Describe the problem

This code isn't updated:

GreetingImage( message = getString(R.string.happy_birthday_text), from = "From Emma", modifier = Modifier.padding(8.dp) )

Instead getString(R.string.happy_birthday_text) must be stringResource(R.string.happy_birthday_text), as the Codelab says.