google-developer-training / basic-android-kotlin-compose-training-affirmations

Apache License 2.0
67 stars 135 forks source link

Practice: Classes and Collections: Android Basics in Compose #5

Closed correabuscar closed 1 year ago

correabuscar commented 2 years ago

Note that you used EVENING here val event6 = Event(title = "Check out latest Android Jetpack library", daypart = Daypart.EVENING, durationInMinutes = 45) which is here: https://developer.android.com/codelabs/basic-android-kotlin-compose-practice-classes-and-collections?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-3-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-practice-classes-and-collections#6 aka on 7. Task 3 However, EVENING would have to be added on previous step on 6. Task 2 Solution which is here: https://developer.android.com/codelabs/basic-android-kotlin-compose-practice-classes-and-collections?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-3-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-practice-classes-and-collections#5

ie. 7evening 6not

correabuscar commented 2 years ago

Oh, I see, my bad, I used the values from 5. Task 2 where there's NIGHT instead of EVENING, therefore, I saw it as missing the EVENING value in 7. Task 3, but in fact, NIGHT on 5. Task 2 should be renamed from NIGHT to EVENING here: https://developer.android.com/codelabs/basic-android-kotlin-compose-practice-classes-and-collections?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-3-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-practice-classes-and-collections#4

5night

correabuscar commented 2 years ago

But also remember that 3. Task 1 here https://developer.android.com/codelabs/basic-android-kotlin-compose-practice-classes-and-collections?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-3-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-practice-classes-and-collections#2 mentions Night in three places so that might need changing into Evening too?

3night

osuleymanova commented 1 year ago

Hello @correabuscar,

Thank you for reaching out to us and providing so valuable description of the issue. The typo "night" is fixed, instead it's supposed to be "evening:"

Screen Shot 2022-11-30 at 2 27 14 PM

Screen Shot 2022-11-30 at 2 15 49 PM