google-developer-training / basic-android-kotlin-compose-training-lemonade

Apache License 2.0
53 stars 27 forks source link

Button colors - mismatch between hints and solution #33

Open fornaeffe opened 1 year ago

fornaeffe commented 1 year ago

Hi, I'm a newbye trying to learn Android Basics with Compose course; I finished the codelab "Click behavior", but I noticed a mismatch between the hints, the pictures of the desired outcome and the solution code.

In hints you suggest to add Modifier.clickable() to the Image composable, but in the solution code you wrapped a Button around the Image. Also in the same hint page you suggest to add a border (2dp, 4dp rounded corners, color = Color(105, 205, 216)) around the image, but the visual effect it's very different from the pictures of the desired output, that instead I obtain with the solution code.

I managed to succesfully finish the codelab, but I think that it will be far more easy if hints are coherent with solution code.

I addition, I noticed that solution code uses Material theme colors, still not treated in the course: I think that will be more understandable for beginners to use color resources...