google-developer-training / basic-android-kotlin-compose-training-mars-photos

Solution code for Android Basics in Kotlin course
https://developer.android.com/courses/android-basics-kotlin/course?gclid=CjwKCAjw4c-ZBhAEEiwAZ105RTyT-iaLHzrhMBUXdMhO230ZDwOwxxI2x4RgK8DwBxK8t1h0wmU_QxoCi4YQAvD_BwE
Apache License 2.0
66 stars 58 forks source link

Add repository and Manual DI inconsistent Repository class name #23

Open DTselikis opened 1 year ago

DTselikis commented 1 year ago

URL of codelab: https://developer.android.com/codelabs/basic-android-kotlin-compose-add-repository?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-5-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-add-repository#8

Specify the language of the codelab if it is not English:

In which task and step of the codelab can this issue be found? Task: "9 Write a repository test" Step: "3 Create an instance of the NetworkMarsPhotosRepository and pass the FakeMarsApiService as the marsApiService parameter."

Describe the problem This step instructs the reader to use the NetworkMarsPhotosRepository which is nonexistent, even though at Step 4 the codelab states that “Remember when you called this function from the MarsViewModel”. I assume it reference the DefaultMarsPhotosRepository from Task 3 “Create Data layer”, step 6. Also, the solution code does indeed has a NetworkMarsPhotosRepository inside MarsPhotosRepository.kt but at no point did the codelab instruct the reader to create it.

Steps to reproduce?

  1. Complete all tasks from 1 to 8.
  2. Upon implementing step 3 of task 9 the NetworkMarsPhotosRepository can not be found.

Versions Android Studio version: Unrelevant API version of the emulator: Unrelevant

Additional information Include screenshots if they would be useful in clarifying the problem. image image