google-developer-training / basic-android-kotlin-compose-training-mars-photos

Solution code for Android Basics in Kotlin course
https://developer.android.com/courses/android-basics-kotlin/course?gclid=CjwKCAjw4c-ZBhAEEiwAZ105RTyT-iaLHzrhMBUXdMhO230ZDwOwxxI2x4RgK8DwBxK8t1h0wmU_QxoCi4YQAvD_BwE
Apache License 2.0
72 stars 66 forks source link

Viewmodel Success Text Change #41

Open cjparent opened 1 year ago

cjparent commented 1 year ago

URL of codelab: https://developer.android.com/codelabs/basic-android-kotlin-compose-add-repository?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-5-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-add-repository#0

Specify the language of the codelab if it is not English:

English

In which task and step of the codelab can this issue be found? Step 10

Describe the problem There is a change in the Success statement of the getMarsPhotos function in MarsViewModel.kt.

In repo start it is: MarsUiState.Success("Success. ${listResult.size} Mars photos retrieved")

However, the period is replaced with a colon in coil-starter branch it is

"Success: ${listResult.size} Mars photos retrieved"

This will ultimately cause the test developed in Step 10 to fail if not fixed in MarsViewModel.kt

Steps to reproduce?

  1. Go to...
  2. Click on...
  3. See error...

Versions Android Studio version: API version of the emulator:

Additional information Include screenshots if they would be useful in clarifying the problem.

getMarsPhotos_coil_starter getMarsPhotos_repo_starter