google-developer-training / basic-android-kotlin-compose-training-mars-photos

Solution code for Android Basics in Kotlin course
https://developer.android.com/courses/android-basics-kotlin/course?gclid=CjwKCAjw4c-ZBhAEEiwAZ105RTyT-iaLHzrhMBUXdMhO230ZDwOwxxI2x4RgK8DwBxK8t1h0wmU_QxoCi4YQAvD_BwE
Apache License 2.0
66 stars 58 forks source link

Add Repository #54

Open Benjamin-Burton opened 1 year ago

Benjamin-Burton commented 1 year ago

URL of codelab: https://developer.android.com/codelabs/basic-android-kotlin-compose-add-repository?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-5-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-add-repository#8

Specify the language of the codelab if it is not English:

In which task and step of the codelab can this issue be found? 9

Describe the problem The codelab in step 9 starts referring to classes that were not created in previous steps. It looks like the naming was refactored in the previous steps and not updated in this step. Specifically there is no class called NetworkMarsPhotosRepository (should be MarsPhotosRepository)

Steps to reproduce? N/A

Versions _Android Studio version:_N/A _API version of the emulator:_N/A

Additional information Include screenshots if they would be useful in clarifying the problem.

machado001 commented 1 year ago

Just rename DefaultMarsPhotosRepository in the data layer to NetworkMarsPhotosRepository or rename NetworkMarsPhotosRepository in the test directory to DefaultMarsPhotosRepository

just be aware that DefaultMarsPhotosRepository = NetworkMarsPhotosRepository