google-developer-training / basic-android-kotlin-compose-training-woof

Apache License 2.0
56 stars 87 forks source link

Simple Animation with Jetpack Compose | Animation run unexpected way #71

Open Jaehwa-Noh opened 1 year ago

Jaehwa-Noh commented 1 year ago

URL of codelab Codelab

In which task and step of the codelab can this issue be found? 7 (Optional) Experiment with other animations - 3

Describe the problem Background color animation does not work I'd expected. Android20231122_222433

Steps to reproduce?

  1. Go to...
  2. Click on...
  3. See error...

Versions Android Studio version: Android Studio Giraffe 2022.3.1 Patch 4 API version of the emulator: 34

Additional information Include screenshots if they would be useful in clarifying the problem.

Suggestion

Need to change modifier chain order. This code change

 Card(modifier = modifier) {
        Column(
            modifier = Modifier
                .animateContentSize(
                    animationSpec = spring(
                        dampingRatio = Spring.DampingRatioNoBouncy,
                        stiffness = Spring.StiffnessMedium
                    )
                )
                .background(color = color)   // <----
        ) { }

to this.

 Card(modifier = modifier) {
        Column(
            modifier = Modifier
                .background(color = color)   // <----
                .animateContentSize(
                    animationSpec = spring(
                        dampingRatio = Spring.DampingRatioNoBouncy,
                        stiffness = Spring.StiffnessMedium
                    )
                )
        ) { }

Result

Android20231122_224300