google-developer-training / pwa-training-labs

Open-source training labs for building Progressive Web Apps
https://developers.google.com/web/ilt/pwa/
Apache License 2.0
587 stars 447 forks source link

constructor error expiration #86

Open MannimMond86 opened 4 years ago

MannimMond86 commented 4 years ago

delete: new workbox.expiration.Plugin() and use new ExpirationPlugin(config) line 30 https://github.com/google-developer-training/pwa-training-labs/blob/master/sw-precache-workbox-lab/solution/app/sw.js

https://developers.google.com/web/tools/workbox/reference-docs/latest/module-workbox-expiration.ExpirationPlugin

best regards Tjark

DavidScales commented 4 years ago

Thanks Tjark. This lab is indeed a bit outdated - Workbox version 3 is used, while version 5 is current. I don't have time currently to update the API, but I will leave this issue as a reminder.

Thanks again!