search

google-gemini / gemma-cookbook

A collection of guides and examples for the Gemma open models from Google.
https://ai.google.dev/gemma/
Apache License 2.0
668 stars 123 forks source link

Fixed "Run in Google Colab" Links for Gemma TPU Inference Tutorials #24

Closed selamw1 closed 3 months ago

selamw1 commented 3 months ago

Somehow the "Run in Google Colab" links were broken, and this PR fixes them.

windmaple commented 3 months ago

Can you just use a simple editor (e.g., vim/emacs) to fix the link w/o touching other parts of the notebook? There are many diffs but all that is needed is to remove an extra 's' in the link.

Also, we are looking into a better merging approach. In the meanwhile, could you pull in the latest main before sending PR?

selamw1 commented 3 months ago

Can you just use a simple editor (e.g., vim/emacs) to fix the link w/o touching other parts of the notebook? There are many diffs but all that is needed is to remove an extra 's' in the link.

Also, we are looking into a better merging approach. In the meanwhile, could you pull in the latest main before sending PR?

For the first notebook removing 's' would fix for the broken link: gemma_inference_on_tpu.ipynb

However, for the second notebook (titled: gemma_data_parallel_inference_in_jax_tpu.ipynb), its a replica of the first notebook, the whole notebook needs to be changed.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

bebechien commented 3 months ago

I resolved the conflict. Can you run nbfmt for both notebooks to fix the formatting issue?