Add genai.protos - Githubissues

google-gemini / generative-ai-python

The official Python library for the Google Gemini API

https://pypi.org/project/google-generativeai/

Apache License 2.0

1.19k stars 227 forks source link

Add genai.protos #354

Closed MarkDaoust closed 1 month ago

MarkDaoust commented 1 month ago

The main changes are:

Add genai.protos module, just containing from google.ai.generativelanguage_v1beta.types import *.
Replace all proto usage:
- all import google.ai.generativelanguage as glm with from google.generativeai import protos.
- all glm. with protos..
Keep client usage as-isglm.*Client.
Add a test to police glm.
Fix build_docs.py script.

Manual changes:

docs/build_docs.py
google/generativeai/protos.py
tests/test_protos.py

MarkDaoust commented 1 month ago

protos.GenerateContentRequest - that has no use in this SDK, so might be confusing

Yes, it just didn't seem worth sorting through these 1 by one to decide which to include and which not to include.

still refer to google.ai.generativelanguage - I think that's fine, since it's both the truth and a dependency - but it means fields like ToolConfig are no longer linked.

Is there any way we can fix this? Add a find and replace in the generation process?

and maybe doesn't matter with API ref changes coming.

Yeah, that turns it into a real API-reference. But leaves us with nowhere that the SDKs are described in detail?