Closed scottravio closed 7 months ago
This is still an issue when concatenating the value and delimiter results produces a new occurrence of the delimiter. It's presumably uncommon, but I just saw it happen in the wild.
e.g. for the label commit-sha=xxxx524
and the delimiter 5245
^5245^commit-sha=xxxx5245245ref-name=main
yields 245ref-name=main
TL;DR
bug introduced here: https://github.com/google-github-actions/deploy-cloudrun/pull/496
The KV parser creates a delimiter string which does not exist in the input string. This can cause an error when an env var value ends with the start of the delim string.
For instance, if a delim string is
dd
and I have an ENV var SOMETHING=hello-world SOMETHING_ELSE=foo, the string ends up likeSOMETHING=hello-worldddSOMETHING_ELSE=foo
, which creates cloud run ENV variables:Expected behavior
ENV variables correctly parsed
Observed behavior
No response
Action YAML
Log output
No response
Additional information
No response