search

google-github-actions / deploy-cloudrun

A GitHub Action for deploying services to Google Cloud Run.
https://cloud.google.com/run
Apache License 2.0
467 stars 115 forks source link

Add update_strategy for envvars and secrets #523

Closed sethvargo closed 6 months ago

sethvargo commented 6 months ago

The default behavior remains to merge (--update), but setting the update_strategy to "overwrite" will set all values.

Closes https://github.com/google-github-actions/deploy-cloudrun/pull/522

sethvargo commented 6 months ago

Hmm - I'm not sure what's going on. Integration tests are suddenly failing, even at HEAD. It looks like something changed in the node.js test suite with data being shared between filters?

sethvargo commented 6 months ago

Hmm - I'm not sure what's going on. Integration tests are suddenly failing, even at HEAD. It looks like something changed in the node.js test suite with data being shared between filters?

https://github.com/nodejs/node/issues/53033

kosta commented 6 months ago

Thanks a lot 🫶! That was fast :rocket:

kosta commented 6 months ago

Quick FYI: Works like a charm in our deployment. Goodbye env var called # PROXY_SERVER 🥶