google-github-actions / get-gke-credentials

A GitHub Action that configure authentication to a GKE cluster.
https://cloud.google.com/gke
Apache License 2.0
105 stars 41 forks source link

Handle GKE Connect Gateway URL differences #258

Closed sethvargo closed 1 year ago

sethvargo commented 1 year ago

This PR changes the Connect Gateway builder to always lookup the given membership and determine if the resulting cluster is a GKE cluster. If it is a GKE cluster, it uses the /gkeMemberships collection endpoint. Otherwise, it uses the standard /memberships collection endpiont.

It also drops the e2e test in favor of just using kubectl directly.