search

google-github-actions / get-secretmanager-secrets

A GitHub Action for accessing secrets from Google Secret Manager and making them available as outputs.
https://cloud.google.com/secret-manager
Apache License 2.0
145 stars 32 forks source link

Add input for control adding mask for secrets #246

Closed denys-pidlisnyi closed 1 year ago

denys-pidlisnyi commented 1 year ago
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sethvargo commented 1 year ago

Hi @denys-pidlisnyi

I do not want to give users the option to disable masking secrets that come from Google Secret Manager. This could be used to expose secrets in logs.

denys-pidlisnyi commented 1 year ago

Hi @sethvargo

Google Cloud have service like AWS Systems Manager Parameter Store? I use secrets for it.