search

google-github-actions / upload-cloud-storage

A GitHub Action for uploading files to a Google Cloud Storage (GCS) bucket.
https://cloud.google.com/storage
Apache License 2.0
206 stars 49 forks source link

fix: inconsistent path processing for .gcloudignore #358

Open eddielin0926 opened 2 months ago

eddielin0926 commented 2 months ago

Using the repo root for finding ignore files since this action uses the top-level .glcoudignore.

The testcase processes a gcloudignore does not use a longer path in .gcloudignore. Since the given path is testdata, the behavior should remain the same after changing *.txt to testdata/**/*.txt in the testcase.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.